New Quarter Lock/Trap Anti-Overdial prevents going to 127

Moderators: Active DMs, Forum Moderators, Contributors

Post Reply
Distant Relation
Posts: 123
Joined: Wed Jan 05, 2022 12:11 am

New Quarter Lock/Trap Anti-Overdial prevents going to 127

Post by Distant Relation » Thu Apr 07, 2022 2:40 pm

Description
==========
After buying a new quarter, attempting to set trap DC to 127 is impossible if you can't get it to land exactly on 127.

Steps to reproduce
----------------------------
> Buy a new quarter with a Trap DC that starts at 20 (typical).
> Spend coin to raise Trap DC in increments of 3.
> Trap DC reaches 125 (DC 20 base + 35 steps of 3)
> Attempt to raise Trap DC by one more step

Expected result
-----------------------
Trap DC attempts to set it self to 128, failsafes to 127. Trap DC is now at the nominal max.

Actual result
-------------------
Trap DC attempts to set itself to 128. Trap DC upgrade fails due to hitting the cap.

Screenshot(s)
--------------------
n/a

Misc Notes
----------------
This likely would also affect Lock DC, but since Lock DC starts at a different value it does coincidentally manage to land exactly on 127 while upgrading.

Which Server(s)?
------------------------
Guldorand, but likely present on every server

Gaming Platform(s)?
------------------------------
PC

User avatar
KT28
Arelith Gold Supporter
Arelith Gold Supporter
Posts: 162
Joined: Wed Feb 07, 2018 10:53 pm

Re: New Quarter Lock/Trap Anti-Overdial prevents going to 127

Post by KT28 » Thu Apr 07, 2022 3:08 pm

Not actually a bug in exactly the way you describe; it just looks like one. The lock boosting works even if you don't land exactly on the max DC. However, the max DC for traps (just Trap DC, not Lock DC) has always reset to 125 on reset, even before this recent update, so that functionality was not changed.

This 125 max in itself may be a separate bug though. There's nothing in the code that suggests it was intended. I will take a look.

User avatar
KT28
Arelith Gold Supporter
Arelith Gold Supporter
Posts: 162
Joined: Wed Feb 07, 2018 10:53 pm

Re: New Quarter Lock/Trap Anti-Overdial prevents going to 127

Post by KT28 » Thu Apr 07, 2022 3:32 pm

After investigation, the max trap DC being 125 has indeed been a long-term bug that has probably gone unnoticed for years and only became obvious after this update. Fix in the pipeline; you'll finally be able to have traps properly maxed at 127 now.

Distant Relation
Posts: 123
Joined: Wed Jan 05, 2022 12:11 am

Re: New Quarter Lock/Trap Anti-Overdial prevents going to 127

Post by Distant Relation » Thu Apr 07, 2022 9:52 pm

Amazing. Thank you!

Post Reply