Page 2 of 2
Re: Effective CL towards SR
Posted: Tue Aug 06, 2019 5:47 pm
by Xerah
It's been mentioned elsewhere, but we have been looking into why this is happening.
Re: Effective CL towards SR
Posted: Tue Aug 06, 2019 6:44 pm
by BHR55
Once drow and other PC and mob races affected with HAK changes have 41 SR, this will be even more painful.
Thanks for looking into it.
Re: Effective CL towards SR
Posted: Wed Aug 07, 2019 9:38 am
by Artenides
Added this to my list to investigate.
Re: Effective CL towards SR
Posted: Thu Aug 15, 2019 4:40 pm
by Artenides
This has been fixed now. Special thanks to Mord and his magic!
Re: Effective CL towards SR
Posted: Thu Aug 15, 2019 5:02 pm
by Xerah
Given that people felt this was ignored for so long, I wanted to add some additional context.
This was looked in a few times after these bug reports, but no one could see anything wrong with the script. One day, we spent an entire afternoon going line by line through all the scripts in discord making sure we all agreed what each line was doing.
And?
It looked fine.
Then, Artenides added in a ton of debugging feedback and with the help of a few other team members, started testing the spells. Great. It seemed to work. But then it didn't. But then it did. And, wtf?
So, this sat for a bit, trying to figure out why that would happen. The scripts looked fine. Sometimes it was an AoE. Sometimes it was wasn't.
So, then, one thing led to another and Mord started diving deeper into the scripts that were associated with them (called includes, which can sometimes be a large chain). What was discovered is that some of the includes used ALL_CAPS and some did not (this was common in SOU naming for whatever reason).
What it eventually took to fix this was a rebuilt of the custom Arelith compiler (apparently it is the most advanced out there) and a batch replacement of hundreds of scripts to remove these caps. There may have been a few more steps that I missed.
This was an extremely frustrating issue that even held up other development due to the compiler that needed to be fixed.
I hope that gives a picture inside the dev team so that you can understand it is not always just "Change that 1 to a 0!"
Re: Effective CL towards SR
Posted: Thu Aug 22, 2019 8:23 am
by Aren
Well done!
Re: Effective CL towards SR
Posted: Thu Aug 22, 2019 2:55 pm
by Zahlfire_old
Xerah wrote: Thu Aug 15, 2019 5:02 pm
Good stuff
Thank you for the detailed response and explanation of the problem. Kudos to our great dev team.
Re: Effective CL towards SR
Posted: Wed Sep 11, 2019 3:06 pm
by Kalopsia
After some testing on PGCC, I am almost entirely sure Shadow Mages with SD levels also don't get their full CL vs SR.
Perhaps someone could look into this.
Re: Effective CL towards SR
Posted: Wed Sep 11, 2019 7:39 pm
by Apokriphos
Kalopsia wrote: Wed Sep 11, 2019 3:06 pm
After some testing on PGCC, I am almost entirely sure Shadow Mages with SD levels also don't get their full CL vs SR.
Perhaps someone could look into this.
After similar testing, I have noticed that Shadow Mage shadowdancer levels are not counted for dispel resist checks either.