Arelith

Description
==========
For a while, I have not been getting masterful recovery rolls when I roll a 1 on alchemy crafts.

Steps to reproduce
----------------------------
1.) Make an item using the alchemy trade skill where your skill is greater than the DC
2.) Roll a 1

Expected result
-----------------------
I receive a masterful recovery roll to try and not fail to make the craft

Actual result
-------------------
I do not receive the masterful recovery roll and lose the craft.

Screenshot(s)
--------------------

I experienced this as well yesterday. I was crafting some spell components, and on a 1 I directly got the godsave, without masterful recovery.

It's been like this for at least the last 9 months that i've been doing alchemy crafting.

Interesting. Not sure why this would happen at first glance at the code. Can you confirm that this is only alchemy, no other crafts? And that only masterful recoveries fail, not mastery cp bonus on already-started projects?

I get regularly mastery rolls on other projects, after the start.

Mastery rolls use the same formula (re-rolling skill against DC + 20) in two different circumstances: creating a new project and continuing an existing project. It works a slightly different way for each. However, no distinctions are made between handling any of the six tradeskills where Masterful Recoveries are concerned.

In the original screenshot, I see that the failed craft attempt in question tells us that NMan's alchemy skill was only 15 higher than the craft DC. I'd want to confirm that you still fail rolls without ever masterfully recovering where your skill is 20+ higher than the DC. If it's not at least 20 higher, you'll always fail.