Page 1 of 1

Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Tue Mar 29, 2022 10:22 am
by False Nibble
Description of Bug Experienced:
Scroll cases seem to consistently break when placing individual scrolls in them manually (via the scroll case special power). This has happened very often while looting scrolls from shelves and placing them in the case individually.

Steps to reproduce the Bug:
1. Have a scroll case.
2. Have a bunch of unique scroll types (maybe 20 or even close to 50).
3. Put each scroll in the case individually (using the scroll case special power on each scroll separately. Do not use the [Place All Suitable Inventory Items in the Container] option.)
4. Take all the scrolls back out of the case.
5. Repeat steps 3 and 4 until you see the Scroll Case randomly reach capacity before the 50 scroll cap.

Expected Result:
Be able to take scrolls in and out of the case without reaching capacity before the 50 scroll cap.

Actual Result:
Scroll case randomly reaches capacity.

Additional Information/Notes
The usual outcome of this bug is my scroll case being at capacity with 0 scrolls in it, which renders it completely unusable. I think that using the [Place All] option fixes its capacity, but putting all my scrolls in it just to fix it and take them back out is very tedious. For this reason, I have to visit a container fixer almost every time I visit a dungeon that has many shelves with scrolls on them.

I haven't been able to replicate this exact behavior (Scroll Case at capacity with 0 scrolls in it) in simple steps. I think it's a combination of auto looting, taking scrolls manually out of the case and putting individual scrolls in it separately via the Scroll Case Special Power (I never use the [Place All] option which maybe fixes the capacity). This is what my character does and it ends up breaking every time.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Tue Mar 29, 2022 5:53 pm
by Sincra
Looks like I missed a removal or addition recount then. I'll work on this today.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Tue Mar 29, 2022 10:00 pm
by Sincra
Found the potential cause. If for any reason a timer I was using was cancelled it would not empty a "load limiter" mechanism I had employed to reduce processing lag.

This should be resolved in a few resets, I'll put an update out when it goes live, if you use the case when it does in any way it should fix itself after a round or two.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Wed Mar 30, 2022 3:31 am
by Tikin
I've noticed these two:

1_ Can sometimes continue to add, manually and via auto-loot, scrolls in a case filled with more than 50 different types of scrolls.

2_ With 2 scroll cases in inventory, one full one empty, auto scroll loot won't use the empty one. Tried to move around the cases to no avail, tried systematically to use the empty one in hope that the game notices it but with no success. The combat log kept saying "scroll case Y is filled" and put scrolls in inventory without even mention the scroll case X (my cases have different names).

Also, can't help but continue to wonder wether the umbroglio that concern various scrolls origin isn't the real issue with the cases. I mean, I can't even count the different kind (not types) of scrolls that exist. I've seen things like two entries in a case for the same spell in the case, scrolls that wouldn't stack together even after they went throught a case ... I know nothing of the codes that are used in the game, but ain't it a problem for a container ... ? (I remember how some kind of ores were systematically breaking the mining bags ...)
I mean, if the number of scrolls, or the number of types of scrolls were an issue, I'm almost positive it was not systematic ... I had a scroll with way over 100 types of different scrolls and way more than 3000 scrolls, never had any issue with disapearing scrolls.

Hoping these datas can help. I sympathize as it really looks like a bag of knots.

Thanks again for all your work, and good luck ;)

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Wed Mar 30, 2022 8:35 am
by Sincra
Point one is actually related to it not recounting the unique scroll entries inside.

Point two is an unfortunate effect of how inventory searches work and would require another search parameter to make it continue if a container is full to find another. Try moving them around.

Scrolls that don't stack either because they lack new classes in their list of applicables or are tagged as no stack are a common issue, it's mostly handled discretely but as you're right to point out, it's not likely an easy fix without changing a portion of the storage code mechanism.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Wed Mar 30, 2022 11:00 pm
by Tikin
Sincra wrote: Wed Mar 30, 2022 8:35 am Try moving them around.
Tikin wrote: Wed Mar 30, 2022 3:31 am Tried to move around the cases to no avail
To move around the cases used to work, but recently stopped working. ;-)

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Thu Mar 31, 2022 12:11 am
by Sincra
My bad, wrote that just before I went to sleep!

I do not believe any container finding logic was changed so on that end I am uncertain for now.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Thu Mar 31, 2022 8:22 pm
by ElvenEdibles
Auto loot will use the last one placed into your inventory, same as the guys who buy scrolls.

Last night, I had a scroll case that I'd been using manually and it eventually stopped allowing me to put scrolls in it all together (was still able to empty it though). Had to dispose of it.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Fri Apr 01, 2022 12:45 am
by Sincra
Just waiting on a merge still, as I said, I'll announce when it's in.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Sun Apr 03, 2022 2:04 am
by Sincra
This should be fixed, let me know if otherwise.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Sun Apr 03, 2022 10:05 am
by D4wN
It seems like this is happening to other boxes/bags etc. I've noticed where usually I used to be able to hold a large amount of books in my book bag, now I can only hold about 7 before it tells me the container is full. Not sure if this is related?

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Sun Apr 03, 2022 1:38 pm
by False Nibble
The cases look okay so far. The message that they have reached capacity still comes up sometimes, but fixes itself after a round or two. This may be expected behavior, considering you mentioned it in a post above.

Will let you know if anything else comes up, otherwise I suppose this issue can be closed.

Thanks for the quick fix!

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Sun Apr 03, 2022 7:45 pm
by Sincra
D4wN wrote: Sun Apr 03, 2022 10:05 am It seems like this is happening to other boxes/bags etc. I've noticed where usually I used to be able to hold a large amount of books in my book bag, now I can only hold about 7 before it tells me the container is full. Not sure if this is related?

These do not have a limit set so for whatever reason those books just weigh alot.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Sun Apr 03, 2022 9:31 pm
by D4wN
They’re just normal books and notebooks. I can add some screenshots and maybe start a seperate thread for this if you prefer?

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Mon Apr 04, 2022 4:47 am
by Sincra
Please, It really shouldn't be doing any such limiting but maybe I missed a check or there's another bug in the works. I'll be moving this to resolved after the other thread is made.

Re: Scroll Case reaching capacity / breaking when placing in scrolls manually

Posted: Wed Apr 06, 2022 7:40 am
by D4wN
This can be closed for now. Something strange is going on with the container for books. I just need to figure out what it is. I'll open a new thread when / if I do.