Effective CL towards SR

Moderators: Active Admins, Active DMs, Forum Moderators, Area Developers, Artist/Animator, Contributors

Xerah
Posts: 2218
Joined: Wed Sep 23, 2015 5:39 pm

Re: Effective CL towards SR

Post by Xerah »

It's been mentioned elsewhere, but we have been looking into why this is happening.
Katernin Bersk, Chancellor of Divination; Kerri Amblecrown, Paladin of Milil; Xull'kacha Auvry'rae, Redcap Fey-pacted; Sadia yr Thuravya el Bhirax, Priestess of Umberlee; Lissa Whitehorn, Archmage of Artifice
BHR55
Posts: 401
Joined: Thu Jan 17, 2019 5:18 pm

Re: Effective CL towards SR

Post by BHR55 »

Once drow and other PC and mob races affected with HAK changes have 41 SR, this will be even more painful.

Thanks for looking into it.
User avatar
Artenides
Posts: 482
Joined: Mon May 30, 2016 9:19 pm
Location: UK

Re: Effective CL towards SR

Post by Artenides »

Added this to my list to investigate.
--
Plays as: [No active char atm]
"I am a software developer and a DnD nerd. That means I am equally qualified to deal with bugs and bugbears!"
User avatar
Artenides
Posts: 482
Joined: Mon May 30, 2016 9:19 pm
Location: UK

Re: Effective CL towards SR

Post by Artenides »

This has been fixed now. Special thanks to Mord and his magic!
--
Plays as: [No active char atm]
"I am a software developer and a DnD nerd. That means I am equally qualified to deal with bugs and bugbears!"
Xerah
Posts: 2218
Joined: Wed Sep 23, 2015 5:39 pm

Re: Effective CL towards SR

Post by Xerah »

Given that people felt this was ignored for so long, I wanted to add some additional context.

This was looked in a few times after these bug reports, but no one could see anything wrong with the script. One day, we spent an entire afternoon going line by line through all the scripts in discord making sure we all agreed what each line was doing.

And?

It looked fine.

Then, Artenides added in a ton of debugging feedback and with the help of a few other team members, started testing the spells. Great. It seemed to work. But then it didn't. But then it did. And, wtf?

So, this sat for a bit, trying to figure out why that would happen. The scripts looked fine. Sometimes it was an AoE. Sometimes it was wasn't.

So, then, one thing led to another and Mord started diving deeper into the scripts that were associated with them (called includes, which can sometimes be a large chain). What was discovered is that some of the includes used ALL_CAPS and some did not (this was common in SOU naming for whatever reason).

What it eventually took to fix this was a rebuilt of the custom Arelith compiler (apparently it is the most advanced out there) and a batch replacement of hundreds of scripts to remove these caps. There may have been a few more steps that I missed.

This was an extremely frustrating issue that even held up other development due to the compiler that needed to be fixed.

I hope that gives a picture inside the dev team so that you can understand it is not always just "Change that 1 to a 0!"
Katernin Bersk, Chancellor of Divination; Kerri Amblecrown, Paladin of Milil; Xull'kacha Auvry'rae, Redcap Fey-pacted; Sadia yr Thuravya el Bhirax, Priestess of Umberlee; Lissa Whitehorn, Archmage of Artifice
User avatar
Aren
Posts: 722
Joined: Fri Jul 07, 2017 10:27 pm
Location: GMT+1

Re: Effective CL towards SR

Post by Aren »

Well done!

".. the other number that isn't 18." - Jack Oat
".. but- someone is still pumping the brakes sometimes, right? ...right?" - Batcountry

User avatar
Zahlfire_old
Arelith Platinum Supporter
Arelith Platinum Supporter
Posts: 104
Joined: Fri Jul 13, 2018 1:56 am

Re: Effective CL towards SR

Post by Zahlfire_old »

Xerah wrote: Thu Aug 15, 2019 5:02 pm Good stuff
Thank you for the detailed response and explanation of the problem. Kudos to our great dev team.
The GrumpyCat wrote: Sat Feb 29, 2020 2:48 am Perhaps the takeaway is not to go 'Ugh. Lesbians... we should cull them.'
Currently plays: N/A

Who to PM and When

Feel free to PM me with Lore questions!
Kalopsia
General Admin
General Admin
Posts: 1628
Joined: Thu Sep 28, 2017 10:34 am
Location: Concourse Capaneus
Contact:

Re: Effective CL towards SR

Post by Kalopsia »

After some testing on PGCC, I am almost entirely sure Shadow Mages with SD levels also don't get their full CL vs SR.
Perhaps someone could look into this.
Apokriphos
Posts: 155
Joined: Tue Jul 30, 2019 4:14 pm

Re: Effective CL towards SR

Post by Apokriphos »

Kalopsia wrote: Wed Sep 11, 2019 3:06 pm After some testing on PGCC, I am almost entirely sure Shadow Mages with SD levels also don't get their full CL vs SR.
Perhaps someone could look into this.
After similar testing, I have noticed that Shadow Mage shadowdancer levels are not counted for dispel resist checks either.
Post Reply