On Hit Ability Rework

[Mattamue]

Description of Bug Experienced:
Testing out the On Hit rework on the PGCC. Expected to be able to stack all of these "on hit" abilities and see them in the new screen, but they did not work.

Flame Weapon on a bronze scimitar
Inflict Wounds from Blackguard
Blackstaff
Temp 1d6 fire essence
Elemental Rhyme custom poison
Magic imbue
Cold imbue
Divine might
3 swash damage

Steps to reproduce the Bug:
Apply all these "on hit" spells and items.

Expected Result:
All the effects come through.

Actual Result:
Only some damage properties came through and no imbue effects, blackstaff, or poison.

Side note -- I forgot to mention it in the screen shot, but the swash 3 piercing damage was gone off the character sheet too.

Screenshot(s)


Additional Information/Notes
Love the enhancement! Hope this helps get it online.

[Zaphiel]

So first of all, this update has nothing to do about item properties (property is the texts that is blue colored when you examine the item) except On Hit: Unique Power (OnHit) Level X. So, behaviours on them have not changed at all. You will still unable to stack essences, imbues, blackguard inflict wounds, etc. to weapon. You will still lose your imbues when you apply keen edge last. So, spell casting ordering is matter. (Casting keen edge then imbues won't remove benefits of keen edge for example. But casting imbues first then keen edge will remove the imbues.) Also, if an item property that is granted as class bonus is lost, it should be reported independently from on hit ability.

Now, thank you for report. I have looked at it and found some issues with poison and now it is fixed. I will be sending it's fix soon.
Another thing that I have identified is, Flame Weapon spell's itemproperty (On Hit: Flaming Weapon Properties (Fire Damage) bla bla) prevents On Hit: Unique Power (OnHit) Level X item property event being fired. Will see if something can be done.

[Zaphiel]

Fix sent for both.