Dreadnought refueling prints the wrong value

Moderators: Active Admins, Active DMs, Forum Moderators, Contributors

Locked
Gerhazo
Posts: 63
Joined: Wed Jun 28, 2023 3:13 pm

Dreadnought refueling prints the wrong value

Post by Gerhazo »

(I assume this falls under "general mechanics")

Description of Bug Experienced:
Dreadnought, Andunor's ironclad ship, is fueled by depositing coal in the "Coal Powered Furnace" in its lowerdecks.
After putting coal into the storage item, it is consumed and the user receives a notice about the current fuel/coal numbers.

The number provided is incorrect: it provides the Dreadnought's fuel -before- adding the coal, rather than the final result.

Steps to reproduce the Bug:

  1. Example: Dreadnought is at 2980 fuel. (can be checked by checking the -ship stats on the deck)
  2. Add 1 coal to the Dreadnought.
    Receive message: "Coal added to the furnace. Currently 2980 unit(s) of coal in storage.
    Real and expected value: 2891 units of coal.
  3. Add 10 coal to the Dreadnought.
    Receive message: "Coal added to the furnace. Currently 2981 unit(s) of coal in storage.
    Real and expected value: 2991 units of coal.
  4. Add 1 coal to the Dreadnought.
    Receive message: "Coal added to the furnace. Currently 2991 unit(s) of coal in storage.
    Real and expected value: 2992 units of coal.

Expected Result:
Dreadnought displays the total fuel after adding the coal.

Actual Result:
Dreadnought displays the fuel before adding the coal.

Additional Information/Notes
There are significant odds that the other ironclad ship, the Ironhelm, might also be affected by this, unless it doesn't share the fuel logic with Dreadnought.

User avatar
Iceborn
Contributor
Contributor
Posts: 3472
Joined: Thu Jun 11, 2015 2:31 am
Location: Dancing on the line between sarcasm and irony

Re: Dreadnought refueling prints the wrong value

Post by Iceborn »

Gerhazo wrote: Fri Aug 16, 2024 2:12 pm

(I assume this falls under "general mechanics")

Description of Bug Experienced:
Dreadnought, Andunor's ironclad ship, is fueled by depositing coal in the "Coal Powered Furnace" in its lowerdecks.
After putting coal into the storage item, it is consumed and the user receives a notice about the current fuel/coal numbers.

The number provided is incorrect: it provides the Dreadnought's fuel -before- adding the coal, rather than the final result.

Steps to reproduce the Bug:

  1. Example: Dreadnought is at 2980 fuel. (can be checked by checking the -ship stats on the deck)
  2. Add 1 coal to the Dreadnought.
    Receive message: "Coal added to the furnace. Currently 2980 unit(s) of coal in storage.
    Real and expected value: 2891 units of coal.
  3. Add 10 coal to the Dreadnought.
    Receive message: "Coal added to the furnace. Currently 2981 unit(s) of coal in storage.
    Real and expected value: 2991 units of coal.
  4. Add 1 coal to the Dreadnought.
    Receive message: "Coal added to the furnace. Currently 2991 unit(s) of coal in storage.
    Real and expected value: 2992 units of coal.

Expected Result:
Dreadnought displays the total fuel after adding the coal.

Actual Result:
Dreadnought displays the fuel before adding the coal.

Additional Information/Notes
There are significant odds that the other ironclad ship, the Ironhelm, might also be affected by this, unless it doesn't share the fuel logic with Dreadnought.

Finally, somebody that matches my level of pedantry. Our bugfixing shall be le-... well, largely inconsequential, but it's nice.
A fix is in the pipeline.

Locking and archiving.

Don't click weird links, kiddos.

Locked